• 39 Posts
  • 271 Comments
Joined 1 year ago
cake
Cake day: June 23rd, 2023

help-circle




  • Ew no.

    Abusing language features like this (boolean expression short circuit) just makes it harder for other people to come and maintain your code.

    The function does have opportunity for improvement by checking one thing at a time. This flattens the ifs and changes them into proper sentry clauses. It also opens the door to encapsulating their logic and refactoring this function into a proper validator that can return all the reasons a user is invalid.

    Good code is not “elegant” code. It’s code that is simple and unsurprising and can be easily understood by a hungover fresh graduate new hire.
















  • I have to say that this is the most color I’ve seen in months on the actual reasons why. On first read, it gives an understanding that both sides are willing to approach a deal - but lack trust in the process and the mediators ability to coerce the other side to actually commit and follow through.

    A more cynical read (my second one) through this is that Hamas is still viewing civilian hostages as an asset and leverage. They are hesitant to get a six week ceasefire because they think they should get more than that for civilian hostages. Recent reports are making it clear that Hamas is executing the hostages. Whether as part of their negotiations, a breakdown in discipline, or just simple evil - the mediators have failed to impress upon Hamas the depth of their strategic mistake.